Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Aug 13, 2025

Issue # (if applicable)

n/a

Reason for this change

The core docs currently shown in the API Reference (as of before this PR is merged), is the one at packages/aws-cdk-lib/README.md and not packages/aws-cdk-lib/core/README.md.

Both have a lot of duplication, but there is content that has been added to the core README that is missing from the main doc.

A long time ago we enforced both files to have the have the same content, but this got lost in the big repo remodel of 2023.

Description of changes

I'm removing the core README.md in favor of the top-level one.
All missing content has been backported and some additional fixes where made.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

I checked and none of the places we publish to uses the current core README.md. This is because the contents get dropped as part of the jsii compilation and doesn't end up in the jsii assembly.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner August 13, 2025 13:58
@aws-cdk-automation aws-cdk-automation requested a review from a team August 13, 2025 13:58
@github-actions github-actions bot added the p2 label Aug 13, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 13, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 13, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e07c89b into main Aug 13, 2025
18 checks passed
@mergify mergify bot deleted the mrgrain/docs/fix-readme branch August 13, 2025 16:50
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants