Skip to content

Conversation

@alexandersperling
Copy link
Contributor

  • Use new transform to update from deprecated python 3.9 lambda runtime

Issue # (if applicable)

Closes #34168

Reason for this change

  • Lambda runtime python 3.9 is marked for deprecation and therefore should be updated

Description of changes

  • Use new serverless transformation

Describe any new or updated permissions being added

none

Description of how you validated changes

existing unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

* Use new transform to update from deprecated python 3.9 lambda runtime
@aws-cdk-automation aws-cdk-automation requested a review from a team August 11, 2025 07:28
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Aug 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@alexandersperling alexandersperling changed the title fix(aws-secretsmanager): Secret transformation fix(secretsmanager): Secret transformation Aug 11, 2025
@alexandersperling alexandersperling changed the title fix(secretsmanager): Secret transformation fix(secretsmanager): secret transformation Aug 11, 2025
@alexandersperling
Copy link
Contributor Author

Clarification Request
It is not possible for me to run an integration test in my current AWS account. Would be someone so kind, do this and update this MR accordingly?

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Aug 11, 2025
@aemada-aws aemada-aws self-assigned this Sep 16, 2025
@aemada-aws aemada-aws removed their assignment Sep 17, 2025
@alvazjor alvazjor self-assigned this Sep 17, 2025
@alvazjor alvazjor removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Sep 17, 2025
@alvazjor
Copy link
Contributor

alvazjor commented Sep 17, 2025

I downloaded the branch to my local, and confirmed the changes are generating the rotation lambdas using python 3.10. I will add a exception to the test since they are in a nested stack within the integ tests stacks, and they are not being recognized, but I did check they end up creating lambdas with python v 3.10 for test packages/@aws-cdk-testing/framework-integ/test/aws-secretsmanager/test/integ.hosted-rotation.ts

@alvazjor alvazjor added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Sep 17, 2025
alvazjor
alvazjor previously approved these changes Sep 17, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 17, 2025 16:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot dismissed alvazjor’s stale review September 17, 2025 16:14

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f4b26af into aws:main Sep 17, 2025
20 of 21 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws secrets manager): addRotationSingleUser() creates a lambda on python 3.9 which is announced for deprecation

4 participants