chore(ci): disable branch protection rules in mergify #35189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alisen Berat Ozel <null>
aws-cdk-automation
previously requested changes
Aug 8, 2025
ozelalisen
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
previously requested changes
Aug 8, 2025
| - -closed | ||
| - "#approved-reviews-by>=1" | ||
| - -approved-reviews-by~=author | ||
| # This is important! It makes the PR Linter work. |
There was a problem hiding this comment.
Arguably these comments are very useful. Can we keep them pls?
There was a problem hiding this comment.
That is why I kept it do-not-merge, will keep them
alvazjor
approved these changes
Aug 11, 2025
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has been made by @ozelalisen from the Mergify Queue Rule Configurator.
Mergify does not sync branch protection rules. Overall disabling won't hurt because we have the same checks exist in mergify config already and branch protection rules won't even allow direct merge. It is already duplicate rule checking to include branch protection rules in mergify.