ci: use check-success instead of status-success for GitHub Actions #35188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvazjor
changed the title
aws-cdk-automation
previously requested changes
Aug 8, 2025
Abogical
added
pr-linter/exempt-test
Abogical
approved these changes
Aug 8, 2025
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Abogical
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
After removing the CodeBuild requirement from Mergify in #35174, automatic PR merging stopped working. Mergify was looking for status-success=validate-pr and status-success=build, but GitHub Actions creates check runs, not statuses. CodeBuild used the GitHub Status API, while GitHub Actions uses the GitHub Checks API.
Description of changes
Changed all Mergify conditions from status-success=validate-pr and status-success=build to check-success=validate-pr and check-success=build to match what GitHub Actions actually creates.
The previous configuration worked because Mergify was only waiting for the CodeBuild status (which was correctly configured), while the GitHub Actions conditions were silently failing but not blocking merges.
Describe any new or updated permissions being added
NA
Description of how you validated changes
Analyzed GitHub API responses for recent PRs to confirm:
• CodeBuild creates statuses via GitHub Status API
• GitHub Actions creates check runs via GitHub Checks API
• Verified that approved PRs have successful validate-pr and build check runs but no corresponding statuses
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license