Skip to content

docs(autoscaling): fix maxInstanceLifetime docs #35181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2025
Merged

docs(autoscaling): fix maxInstanceLifetime docs #35181

merged 3 commits into from
Aug 8, 2025

Conversation

@domestic-fennec
Copy link
Contributor

This aligns the cdk docs with the code and AWS docs

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@domestic-fennec
chore(autoscaling) fix maxInstanceLifetime docs
1753455 
This aligns the docs with the code and AWS docs
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Aug 6, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team August 6, 2025 23:05
@github-actions github-actions bot added the p2 label Aug 6, 2025
@domestic-fennec
Update README.md
5965b42 
squash me
aws-cdk-automation
aws-cdk-automation previously requested changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5965b42
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@domestic-fennec domestic-fennec changed the title chore(autoscaling) fix maxInstanceLifetime docs docs(autoscaling): fix maxInstanceLifetime docs Aug 7, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 7, 2025 09:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 7, 2025
kaizencc
kaizencc approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 7, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ozelalisen
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2025

refresh

✅ Pull request refreshed

@vishaalmehrishi
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2025

refresh

✅ Pull request refreshed

@ozelalisen
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2025

refresh

✅ Pull request refreshed

@vishaalmehrishi vishaalmehrishi merged commit 2d86f98 into aws:main Aug 8, 2025
17 of 19 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@domestic-fennec @aws-cdk-automation @ozelalisen @vishaalmehrishi @kaizencc