Skip to content

Conversation

@alvazjor
Copy link
Contributor

@alvazjor alvazjor commented Aug 5, 2025

Issue # (if applicable)

Closes #.

Reason for this change

All ISO partitions now support Node22, so this PR updates the Node runtime version in all of them. Also, now the NODEJS_LATEST variable in lambda runtime definition uses Node22, as all supported partitions have reached parity, being Node22 the latest available version in all of them

Description of changes

Updated node runtime mappings in fact-table, updated NODEJS_LATEST to map to Node22 and updated all related unit and integration tests

Describe any new or updated permissions being added

NA

Description of how you validated changes

Local deployment of all the updated integration tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@alvazjor alvazjor added pr/work-in-progress This PR is a draft and needs further work. pr/do-not-merge This PR should not be merged at this time. labels Aug 5, 2025
@github-actions github-actions bot added the p2 label Aug 5, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team August 5, 2025 16:35
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 5, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@alvazjor alvazjor force-pushed the alvazjor/update-node-js branch 3 times, most recently from c422a4d to f633300 Compare August 6, 2025 23:54
@alvazjor alvazjor changed the title feat: update node js runtime version in ADCs chore: update node js runtime version in ADCs Aug 6, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 6, 2025 23:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@alvazjor alvazjor force-pushed the alvazjor/update-node-js branch 2 times, most recently from 70499b8 to e6dc1fb Compare August 7, 2025 01:02
@aws-cdk-automation

This comment was marked as outdated.

@alvazjor alvazjor force-pushed the alvazjor/update-node-js branch from e6dc1fb to dfb0b61 Compare August 7, 2025 12:50
@alvazjor alvazjor requested a review from a team as a code owner August 7, 2025 12:50
@alvazjor alvazjor changed the title chore: update node js runtime version in ADCs chore: update node js runtime version in ISO partitions Aug 7, 2025
@alvazjor alvazjor force-pushed the alvazjor/update-node-js branch from dfb0b61 to d40d434 Compare August 7, 2025 15:10
@alvazjor alvazjor added p1 and removed pr/work-in-progress This PR is a draft and needs further work. pr/do-not-merge This PR should not be merged at this time. p2 labels Aug 7, 2025
@Abogical Abogical assigned Abogical and unassigned Abogical Aug 7, 2025
@Abogical Abogical self-assigned this Aug 7, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Abogical
Copy link
Member

Abogical commented Aug 8, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2025

update

☑️ Nothing to do, the required conditions are not met

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@Abogical
Copy link
Member

Abogical commented Aug 8, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@alvazjor
Copy link
Contributor Author

alvazjor commented Aug 8, 2025

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2025

rebase

☑️ Nothing to do, the required conditions are not met

  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@alvazjor
Copy link
Contributor Author

alvazjor commented Aug 8, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@alvazjor
Copy link
Contributor Author

alvazjor commented Aug 8, 2025

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2025

rebase

☑️ Nothing to do, the required conditions are not met

  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@alvazjor alvazjor merged commit f03f32e into main Aug 8, 2025
44 of 45 checks passed
@alvazjor alvazjor deleted the alvazjor/update-node-js branch August 8, 2025 08:24
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants