Skip to content

fix(eks): remove usage of shell=True in helm commands #35148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025
Merged

fix(eks): remove usage of shell=True in helm commands #35148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f890d14
fix(eks): remove usage of shell=True in helm commands
aemada-aws Aug 5, 2025
882f87c
add p1.kill
aemada-aws Aug 5, 2025
88207de
update integ tests
aemada-aws Aug 5, 2025
08f2ee9
Merge branch 'main' into remove-shell-v1
aemada-aws Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions packages/@aws-cdk-testing/framework-integ/test/aws-eks/.gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.zip filter=lfs diff=lfs merge=lfs -text
0 ...2cafaf131b323fd1f502f2c/apply/__init__.py → ...8ced2ed316a7a6f03f5c9d4/apply/__init__.py
View file
Open in desktop
File renamed without changes.
0 ...c82cafaf131b323fd1f502f2c/get/__init__.py → ...3f8ced2ed316a7a6f03f5c9d4/get/__init__.py
View file
Open in desktop
File renamed without changes.
82 changes: 64 additions & 18 deletions ...82cafaf131b323fd1f502f2c/helm/__init__.py → ...f8ced2ed316a7a6f03f5c9d4/helm/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...efeaa16c82cafaf131b323fd1f502f2c/index.py → ...9e619043f8ced2ed316a7a6f03f5c9d4/index.py
View file
Open in desktop
File renamed without changes.
0 ...2cafaf131b323fd1f502f2c/patch/__init__.py → ...8ced2ed316a7a6f03f5c9d4/patch/__init__.py
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...6b248a2b6eb9e9f6ce75ac58d33a1941/index.js → ...d82c75c3b2f4c87040c9385af73b9299/index.js
View file
Open in desktop

Large diffs are not rendered by default.

34 changes: 17 additions & 17 deletions ...eg/test/aws-eks/test/integ.alb-controller-authapi.js.snapshot/integ-eks-stack.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .../test/aws-eks/test/integ.alb-controller-authapi.js.snapshot/integ-eks-stack.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@
{
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"/9e5735ab13fb0ab98eb443d105c092608811daa53d367ae36289cca965add4c4.json"
"/1cf186b4d089119320de10437dfa334d7b9f08ff99f2c87633f28d225ac8e097.json"
]
]
}
Expand Down Expand Up @@ -991,7 +991,7 @@
{
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"/26a86baa1f7a7274bc43922caad22fa28546b8934343da72395fda351aa5f2aa.json"
"/03063b33cd0e6181b1deeeb06d2eb78f33ad4f71f39310976d3a81023e3cb72d.json"
]
]
}
Expand Down
4 changes: 2 additions & 2 deletions ...js.snapshot/integeksstackawscdkawseksClusterResourceProviderD385D88C.nested.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "75f7b6a23d8f39fbba91063166ea824a6b248a2b6eb9e9f6ce75ac58d33a1941.zip"
"S3Key": "fbe89680da6eb304bf1bd582d61bdb89d82c75c3b2f4c87040c9385af73b9299.zip"
},
"Description": "onEvent handler for EKS cluster resource provider",
"Environment": {
Expand Down Expand Up @@ -123,7 +123,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "75f7b6a23d8f39fbba91063166ea824a6b248a2b6eb9e9f6ce75ac58d33a1941.zip"
"S3Key": "fbe89680da6eb304bf1bd582d61bdb89d82c75c3b2f4c87040c9385af73b9299.zip"
},
"Description": "isComplete handler for EKS cluster resource provider",
"Environment": {
Expand Down
2 changes: 1 addition & 1 deletion ...authapi.js.snapshot/integeksstackawscdkawseksKubectlProvider0B11D13A.nested.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "c491874c6f9e547809cebf58ee410359efeaa16c82cafaf131b323fd1f502f2c.zip"
"S3Key": "623f9dde2c765e8d16b1f59b011a5eea9e619043f8ced2ed316a7a6f03f5c9d4.zip"
},
"Description": "onEvent handler for EKS kubectl resource provider",
"Environment": {
Expand Down
15 changes: 8 additions & 7 deletions .../framework-integ/test/aws-eks/test/integ.alb-controller-authapi.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...ting/framework-integ/test/aws-eks/test/integ.alb-controller-authapi.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

0 ...2cafaf131b323fd1f502f2c/apply/__init__.py → ...8ced2ed316a7a6f03f5c9d4/apply/__init__.py
View file
Open in desktop
File renamed without changes.
0 ...c82cafaf131b323fd1f502f2c/get/__init__.py → ...3f8ced2ed316a7a6f03f5c9d4/get/__init__.py
View file
Open in desktop
File renamed without changes.
Loading
Loading