Skip to content

Conversation

@Abogical
Copy link
Member

@Abogical Abogical commented Jul 31, 2025

Reason for this change

The parameter name _ caused jsii processing issues for Java versions newer than version 9. This is because _ is a preserved keyword there.

Description of changes

Renamed parameter from _ to _scope instead.

Describe any new or updated permissions being added

No new permissions are added.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added valued-contributor [Pilot] contributed between 6-12 PRs to the CDK p2 labels Jul 31, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 31, 2025 08:26
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 31, 2025
@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Abogical
Copy link
Member Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Abogical
Copy link
Member Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@Abogical
Copy link
Member Author

@Mergifyio rebase

This parameter name caused jsii processing issues for Java versions newer than version 9. This is because '_' is a preserved keyword there.
@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

rebase

✅ Branch has been successfully rebased

@Abogical Abogical force-pushed the ec2-java-reserved-fix branch from f4e34b2 to ead40b6 Compare July 31, 2025 12:37
@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ead40b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6a2bcde into main Jul 31, 2025
20 checks passed
@mergify mergify bot deleted the ec2-java-reserved-fix branch July 31, 2025 13:08
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants