feat(rds): add DatabaseProxyEndpoint L2 construct

[phuhung273]

Issue # (if applicable)

Closes #14186

Reason for this change

Add DatabaseProxyEndpoint L2 construct

Description of changes

• Add DatabaseProxyEndpoint L2 construct
• DatabaseProxy support method addEndpoint

Describe any new or updated permissions being added

Description of how you validated changes

Unit + Integ

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 0ec73b1
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[abidhasan-aws]

Hi @phuhung273
Thanks for your contribution.

I have left some comments :)

[abidhasan-aws]

For the AWS::RDS::DBProxyEndpoint resource in AWS CloudFormation, the dbProxyEndpointName property is required and is not automatically generated. Suggestion: we can make the field required and update the documentation accordingly.

And even if we want to generate the name, the docs should tell that it's "cdk generated" and not "cloudformation generated"

[phuhung273]

It is true that dbProxyEndpointName is required for CloudFormation, CLI,... But I saw the pattern from proxy.ts to take input or generate one and think this way has better user experience.

aws-cdk/packages/aws-cdk-lib/aws-rds/lib/proxy.ts

Lines 461 to 464 in c126e35

	const physicalName = props.dbProxyName || (
	cdk.FeatureFlags.of(this).isEnabled(cxapi.DATABASE_PROXY_UNIQUE_RESOURCE_NAME) ?
	cdk.Names.uniqueResourceName(this, { maxLength: 60 }) : id
	);

So I've updated the docstring to CDK generated. Let me know what you think.

Pull request has been modified.

[abidhasan-aws]

Thanks for making the changes promptly :)

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.