refactor(pipelines): simplify CLI dependency version #34803
Conversation
The Pipelines construct used to inspect `package.json` of the library to come up with the major version of the CDK CLI to use. This made sense when we were dual-running v1 and v2, but now that v1 is deprecated and the version lines of library and CLI have been decoupled, this does not make sense anymore. Just depend on CLI v2 directly, in a clear way.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
The Pipelines construct used to inspect
package.jsonof the library to come up with the major version of the CDK CLI to use.This made sense when we were developing v1 and v2 of CDK at the same time, but now that v1 is deprecated and the version lines of library and CLI have been decoupled, this does not make sense anymore.
Just depend on CLI v2 directly, in a clear way.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license