docs(lambda): warn users on using fromBucket without setting objectVersion #34772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
repeat-contributor
aws-cdk-automation
previously requested changes
Jun 20, 2025
Abogical
changed the title
Abogical
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aemada-aws
reviewed
Jun 25, 2025
| '/Stack/Bucket', | ||
| 'objectVersion is not defined for S3Code.fromBucket(). The lambda will not be updated automatically if the code in the bucket is updated. ' + | ||
| 'This is because CDK/Cloudformation does not track changes on the source S3 Bucket. It is recommended to either use S3Code.fromAsset() instead or set objectVersion. ' + | ||
| '[ack: @aws-cdk/aws-lambda:codeFromBucketObjectVersionNotSpecified]' |
There was a problem hiding this comment.
Suggested change
| '[ack: @aws-cdk/aws-lambda:codeFromBucketObjectVersionNotSpecified]' | |
| '[ack: @aws-cdk/aws-lambda:codeFromBucketObjectVersionNotSpecified]', |
this fixes the lint failure
aemada-aws
approved these changes
Jun 25, 2025
Abogical
force-pushed
the
code-from-bucket-warn
branch
from
6884652 to
dc38028
Compare
Abogical
force-pushed
the
code-from-bucket-warn
branch
from
dc38028 to
a3b2f08
Compare
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6176
Closes #6176.
Reason for this change
Using fromBucket to source lambda code can have the unintended silent effect of not updating when the code is updated on the S3 bucket.
Description of changes
objectVersionis not set.Describe any new or updated permissions being added
No permissions added.
Description of how you validated changes
Unit tests to confirm the emission of warnings only if an object version is not set.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license