-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(bedrockprompt): add prompt management to bedrock agents #34754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dineshSajwan Added initial comments. Not fully done reviewing the full PR but in the mean time, you can start addressing what I already added. Thanks!
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/prompt-variant.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/chat-prompt-variant.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/chat-prompt-variant.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/text-prompt-variant.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/text-prompt-variant.ts
Outdated
Show resolved
Hide resolved
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
2 similar comments
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/inference-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/prompt-variant.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/prompt-variant.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/prompt-variant.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/text-prompt-variant.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/agent-prompt-variant.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/chat-prompt-variant.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-bedrock-alpha/bedrock/prompts/prompt-inference-configuration.ts
Show resolved
Hide resolved
| /** | ||
| * The tools available to the model. | ||
| */ | ||
| readonly tools: CfnPrompt.ToolProperty[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also missed this L1 still being exposed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad , added the abstraction for L2. 45ae2e7
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
This change adds comprehensive support for Amazon Bedrock Prompt Management to the aws-bedrock-alpha package.
Description of changes
Amazon Bedrock Prompt Management allows users to create, save, and version prompts to streamline AI workflows and ensure consistent prompt usage across different applications.
Prompt Construct : Main construct for creating and managing Bedrock prompts with support for multiple variants.
Prompt Variants: Three types of prompt variants:
TextPromptVariant: Simple text-based prompts with variable substitutionChatPromptVariant: Conversational prompts supporting system messages, message history, and tool configurationsAgentPromptVariant: Prompts designed for integration with Bedrock AgentsPrompt Versioning :
PromptVersionconstruct for creating immutable snapshots of promptsTool Configuration : Support for tool choice and tool specifications in chat prompts
Prompt Routing : Integration with Amazon Bedrock intelligent prompt routing for cost optimization
Describe any new or updated permissions being added
bedrock:GetPrompt- Required to retrieve prompt details (granted viagrantGet()method)Description of how you validated changes
Added Unit test and Integration test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license