Skip to content

Conversation

@mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jun 17, 2025

Issue # (if applicable)

Closes #32923.

Reason for this change

To support express brokers.

Description of changes

Add express property and validations about express limitations.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Add unit tests and an integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 17, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 17, 2025 14:11
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jun 17, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 19, 2025 10:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mazyu36 mazyu36 marked this pull request as ready for review June 20, 2025 01:27
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 23, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dea8360
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I thought it might be a good idea to add a validation to ensure that the Kafka version is 3.6 or higher, but it also feels a bit excessive.
I’d appreciate it if you could discuss with the maintainer.

@badmintoncryer
Copy link
Contributor

@mazyu36 Cloud you please update PR title? It results updating PR labels.

@mazyu36 mazyu36 changed the title feat(msk): support Express Brokers feat(msk): support Express brokers Sep 20, 2025
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Sep 20, 2025
@mazyu36 mazyu36 had a problem deploying to deployment-integ-test October 7, 2025 12:54 — with GitHub Actions Error
@kumsmrit kumsmrit self-assigned this Oct 8, 2025
Copy link

@kumsmrit kumsmrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I have added some review comments.

*
* @default false
*/
readonly express?: boolean;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we switch from using boolean to enum instead readonly brokerType?: BrokerType; keeping it more future proof ?

enum BrokerType {
   STANDARD = 'STANDARD', 
   EXPRESS = 'EXPRESS' 
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Added Enum.

throw new core.ValidationError('EBS volume size should be in the range 1-16384', this);
}

if (props.express) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSK ExpressBroker is supported only on Apache Kafka 3.6 and 3.8; Can we add that validation please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a validation.

You can create an MSK cluster with Express Brokers by setting the `express` property to `true`. Express Brokers are a low-cost option for development, testing, and workloads that don't require the high availability guarantees of standard MSK cluster.
For more information, see [Amazon MSK Express Brokers](https://docs.aws.amazon.com/msk/latest/developerguide/msk-broker-types-express.html).

**Note:** When using Express Brokers, the following constraints apply:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It would also be good to include information about the supported broker sizes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mazyu36 mazyu36 requested a review from kumsmrit October 24, 2025 11:26
kumsmrit
kumsmrit previously approved these changes Oct 24, 2025
Copy link

@kumsmrit kumsmrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the comments.

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 24, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mazyu36
Copy link
Contributor Author

mazyu36 commented Oct 24, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2025

update

☑️ Nothing to do, the required conditions are not met

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@mergify mergify bot dismissed kumsmrit’s stale review October 27, 2025 11:32

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0a69e5f into aws:main Oct 27, 2025
21 of 22 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-msk-alpha: Allow specifying the broker type

4 participants