Skip to content

Conversation

@thoyles
Copy link
Contributor

@thoyles thoyles commented Jun 16, 2025

Issue # (if applicable)

Closes part of #33356.

Reason for this change

Recent changes to the aws-glue-alpha package removed WorkerType.of() and JobType.of() but the documentation remained leading to some confusion when investigating compilation errors. After reviewing the PR that initially removed the methods I believe this is the preferred direction for the package.

Description of changes

Removed the comments referring to these methods.

If it would be preferable to re add the WorkerType.of() and JobType.of() methods I'm happy to adjust this PR accordingly.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Removed comments, ensured that yarn build still completed

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jun 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 16, 2025 17:29
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 16, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@thoyles thoyles changed the title Remove documentation referring to .of() access to the constructors of WorkerType and JobType chore(glue-alpha): Remove documentation referring to .of() access to the constructors of WorkerType and JobType Jun 16, 2025
@thoyles thoyles changed the title chore(glue-alpha): Remove documentation referring to .of() access to the constructors of WorkerType and JobType chore(glue-alpha): remove documentation referring to .of() access to the constructors of WorkerType and JobType Jun 16, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 16, 2025 17:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 16, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6fbd3c3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ozelalisen
ozelalisen previously approved these changes Aug 26, 2025
Copy link
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozelalisen ozelalisen self-assigned this Aug 26, 2025
@mergify mergify bot dismissed ozelalisen’s stale review August 26, 2025 15:59

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fc2fc9d into aws:main Aug 26, 2025
20 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants