-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(glue-alpha): remove documentation referring to .of() access to the constructors of WorkerType and JobType #34734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… WorkerType and JobType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes part of #33356.
Reason for this change
Recent changes to the aws-glue-alpha package removed WorkerType.of() and JobType.of() but the documentation remained leading to some confusion when investigating compilation errors. After reviewing the PR that initially removed the methods I believe this is the preferred direction for the package.
Description of changes
Removed the comments referring to these methods.
If it would be preferable to re add the WorkerType.of() and JobType.of() methods I'm happy to adjust this PR accordingly.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Removed comments, ensured that yarn build still completed
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license