Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 15, 2025

Our GitHub repository has 77 files that should have been in LFS, but aren't because a contributor didn't install LFS before contributing.

This is an easy mistake to make.

Add a GitHub workflow that will fail if there are any files that should have been in LFS, but aren't.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Our GitHub repository has 77 files that should have been in LFS, but
aren't because a contributor didn't install LFS before contributing.

This is an easy mistake to make.

Add a GitHub workflow that will fail if there are any files that
should have been in LFS, but aren't.
@rix0rrr rix0rrr requested a review from a team June 15, 2025 18:22
@aws-cdk-automation aws-cdk-automation requested a review from a team June 15, 2025 18:22
@github-actions github-actions bot added the p2 label Jun 15, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 15, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 15, 2025
jobs:
check-lfs:
steps:
- uses: MPLew-is/[email protected] No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I support this, seems more secure to just run

git lfs fsck --pointers

directly ourselves?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7a74ca3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9abd4eb into main Jun 16, 2025
17 checks passed
@mergify mergify bot deleted the huijbers/check-lfs branch June 16, 2025 09:03
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants