feat(ec2): volume initialization rate for EBS volume

[badmintoncryer]

Issue # (if applicable)

None

Reason for this change

AWS EBS now supports for specifying volume initialization rate but AWS CDK cannot configure this parameter.

Description of changes

• Add volumeInitializationRate to VolumeProps

Describe any new or updated permissions being added

none

Description of how you validated changes

Add both unit and integ tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aemada-aws]

why do we need this change?

[badmintoncryer]

This is my mistake. I've reverted now.

[aemada-aws]

Suggested change

	const rateMiBs = props.volumeInitializationRate.toBytes() / (1024 * 1024);
	const rateMiBs = props.volumeInitializationRate.toMebibytes();

[badmintoncryer]

Same as other comment, I think this is not worked for the Size less than 1 MiB.

[aemada-aws]

Suggested change

	}).toThrow(`volumeInitializationRate must be between 100 and 300 MiB/s, got: ${rate.toBytes() / (1024 * 1024)} MiB/s`);
	}).toThrow(`volumeInitializationRate must be between 100 and 300 MiB/s, got: ${rate.toMebibytes()} MiB/s`);

[badmintoncryer]

I think this code is not worked for the Size less than 1 MiB.

[aemada-aws]

why wouldn't it? internally it does the same thing

  public static readonly Mebibytes = new StorageUnit('mebibytes', 1024 * 1024);

function convert(amount: number, fromUnit: StorageUnit, toUnit: StorageUnit, options: SizeConversionOptions = {}) {
  const rounding = options.rounding ?? SizeRoundingBehavior.FAIL;
  if (fromUnit.inBytes === toUnit.inBytes) { return amount; }
  if (Token.isUnresolved(amount)) {
    throw new Error(`Size must be specified as 'Size.${toUnit}()' here since its value comes from a token and cannot be converted (got Size.${fromUnit})`);
  }

  const multiplier = fromUnit.inBytes / toUnit.inBytes;
  const value = amount * multiplier;
  switch (rounding) {
    case SizeRoundingBehavior.NONE:
      return value;
    case SizeRoundingBehavior.FLOOR:
      return Math.floor(value);
    default:
    case SizeRoundingBehavior.FAIL:
      if (!Number.isInteger(value)) {
        throw new Error(`'${amount} ${fromUnit}' cannot be converted into a whole number of ${toUnit}.`);
      }
      return value;
  }
}

[badmintoncryer]

I apologize for the lack of clarity.

When a value of 1MiB or more is input, an intuitive error message is returned, but otherwise only '${amount} ${fromUnit}' cannot be converted into a whole number of ${toUnit}. is returned, making it difficult for users to understand where the problem lies.

I think it is better to display

volumeInitializationRate must be between 100 and 300 MiB/s, got: 0.5 MiB/s

than

'${amount} ${fromUnit}' cannot be converted into a whole number of ${toUnit}..

[aemada-aws]

SizeRoundingBehavior should allow you to modify that, the default is fail.

toMebibytes({ rounding: SizeRoundingBehavior.NONE })

[badmintoncryer]

Thank you for nice information. I've updated to use it.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 76c698a
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository