-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(cognito): support refresh token rotation #34360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
b52d6de
interface
e4a01f1
refresh token rotation
iridescent99 31471b4
Merge branch 'main' into cognito/refresh-token
iridescent99 99b71fd
Add tests + readme
iridescent99 8c49a97
mc
iridescent99 66d17dd
cleanup
iridescent99 50e0606
cleanup
iridescent99 1709d36
ok
iridescent99 a387ed9
fixpj
iridescent99 9b46947
readonly
iridescent99 bba77e7
Merge branch 'main' into cognito/refresh-token
iridescent99 df72d98
test
iridescent99 457574e
fix
iridescent99 299ce0c
linting
iridescent99 c078599
tests
iridescent99 d9436d8
fixtest
iridescent99 97d5352
unittests
iridescent99 14e0723
tests
iridescent99 ac0bef5
Merge branch 'main' into cognito/refresh-token
iridescent99 1797e9c
align
iridescent99 d710bc6
ok
iridescent99 948372e
fixes
iridescent99 cfdc187
Merge branch 'main' into cognito/refresh-token
iridescent99 062bc62
trailingcomma
iridescent99 acbad9e
Merge branch 'cognito/refresh-token' of github.com:iridescent99/aws-c…
iridescent99 d725562
Merge branch 'main' into cognito/refresh-token
iridescent99 a66dd6a
feedback
iridescent99 2be35a8
lint
iridescent99 1925a66
lint
iridescent99 0544a67
ok
iridescent99 bb498b9
identation
iridescent99 e8c25c3
Merge branch 'main' into cognito/refresh-token
iridescent99 7221dc8
Remove feature from interface
iridescent99 acc574c
linter
iridescent99 91740dc
integ test
iridescent99 3d209e3
Remove redundant duration constraint check
iridescent99 60d5e9c
changes
iridescent99 4c2007c
remove redundant test
iridescent99 74421e7
do not set undefined
iridescent99 0adb323
mc
iridescent99 f2d0e69
Merge branch 'main' into cognito/refresh-token
iridescent99 4648851
flatten
iridescent99 9e69d5d
ok
iridescent99 d8e3479
readme
iridescent99 be7a6c9
shorten
iridescent99 ca76127
lint
iridescent99 83e770a
Merge branch 'main' into cognito/refresh-token
ozelalisen ad0a2c5
mc
iridescent99 bd067be
propname
iridescent99 07162a8
Merge branch 'main' into cognito/refresh-token
ozelalisen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reading this we actually don't need to have an interface given that there is a single field for the
retryGracePeriodwe can move this to theUserPoolClientOptionsand line up with the https://github.com/aws/aws-cdk/blob/ff95e3cd54b4bfa0c2b1d92350f2f5583774dcf4/docs/DESIGN_GUIDELINES.md#flat (when I first reviewed the PR I was under the impression that we would need multiple properties in this interface but it's not the case)A suitable variable name would be something like
refreshTokenRotationGracePeriod