feat(events-targets): support Amazon Data Firehose target using Firehose's `IDeliveryStream` #33798

Tietew · 2025-03-17T06:40:28Z

Issue # (if applicable)

Related to #33757 and #33758

Reason for this change

The module has the KinesisFirehoseStreamV2 target class for Firehose delivery stream.
But it has following issues:

Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class should not be called Kinesis. Also, KinesisFirehoseStream is confusable with Kinesis Data Stream.
The constructor receives internally defined IDeliveryStream which is a subset of aws_kinesisfirehose.IDeliveryStream without inheritance. This may cause jsii type compatibility problem.

Description of changes

Added a new FirehoseDeliveryStream target class derived from KinesisFirehoseStreamV2 but receives aws_kinesisfirehose.IDeliveryStream instead.
Deprecated KinesisFirehoseStreamV2 and internal IDeliveryStream.
Added missing unit tests for FirehoseDeliveryStream
Updated the integ test to use FirehoseDeliveryStream and assertions.
Added an missing README entry refers Amazon Data Firehose.

Describe any new or updated permissions being added

N/A - FirehoseDeliveryStream adds same permissions as KinesisFirehoseStreamV2

Description of how you validated changes

Unit tests and integ test.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

codecov · 2025-03-17T06:49:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (a67c3f5) to head (286b140).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33798   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         120      120           
  Lines        6960     6960           
  Branches     1175     1175           
=======================================
  Hits         5735     5735           
  Misses       1120     1120           
  Partials      105      105

Flag	Coverage Δ
suite.unit	`82.39% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`82.39% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…o `FirehosePutRecord` (#33758) ### Issue # (if applicable) Related to #33757 and #33798 ### Reason for this change Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis. ### Description of changes - Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord` - Updated related tests and documents. ### Describe any new or updated permissions being added Nothing changed. ### Description of how you validated changes Updated tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

…o `FirehosePutRecord` (aws#33758) ### Issue # (if applicable) Related to aws#33757 and aws#33798 ### Reason for this change Kinesis Data Firehose is now Amazon Data Firehose. Therefore the class `KinesisDataFirehosePutRecord` should not be called Kinesis. ### Description of changes - Renamed `KinesisDataFirehosePutRecord` to `FirehosePutRecord` - Updated related tests and documents. ### Describe any new or updated permissions being added Nothing changed. ### Description of how you validated changes Updated tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) BREAKING CHANGE: The class `KinesisDataFirehosePutRecord` has been renamed to `FirehosePutRecord`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws-cdk-automation · 2025-07-29T09:38:32Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: e566700
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/aws-cdk-lib/aws-events-targets/lib/firehose.ts

Abogical · 2025-10-27T13:07:58Z

@Mergifyio update

mergify · 2025-10-27T13:08:08Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov-collect.yml without workflows permission

Pull request has been modified.

Abogical

1 snapshot needs to be updated due to upgrade to node22:

@aws-cdk-testing/framework-integ:   CHANGED    aws-events-targets/test/firehose/integ.firehose-delivery-stream 2.24s
@aws-cdk-testing/framework-integ:       Mappings
@aws-cdk-testing/framework-integ:       [-] Mapping LatestNodeRuntimeMap: {"af-south-1":{"value":"nodejs22.x"},"ap-east-1":{"value":"nodejs22.x"},"ap-east-2":{"value":"nodejs22.x"},"ap-northeast-1":{"value":"nodejs22.x"},"ap-northeast-2":{"value":"nodejs22.x"},"ap-northeast-3":{"value":"nodejs22.x"},"ap-south-1":{"value":"nodejs22.x"},"ap-south-2":{"value":"nodejs22.x"},"ap-southeast-1":{"value":"nodejs22.x"},"ap-southeast-2":{"value":"nodejs22.x"},"ap-southeast-3":{"value":"nodejs22.x"},"ap-southeast-4":{"value":"nodejs22.x"},"ap-southeast-5":{"value":"nodejs22.x"},"ap-southeast-6":{"value":"nodejs22.x"},"ap-southeast-7":{"value":"nodejs22.x"},"ca-central-1":{"value":"nodejs22.x"},"ca-west-1":{"value":"nodejs22.x"},"cn-north-1":{"value":"nodejs22.x"},"cn-northwest-1":{"value":"nodejs22.x"},"eu-central-1":{"value":"nodejs22.x"},"eu-central-2":{"value":"nodejs22.x"},"eu-isoe-west-1":{"value":"nodejs18.x"},"eu-north-1":{"value":"nodejs22.x"},"eu-south-1":{"value":"nodejs22.x"},"eu-south-2":{"value":"nodejs22.x"},"eu-west-1":{"value":"nodejs22.x"},"eu-west-2":{"value":"nodejs22.x"},"eu-west-3":{"value":"nodejs22.x"},"eusc-de-east-1":{"value":"nodejs22.x"},"il-central-1":{"value":"nodejs22.x"},"me-central-1":{"value":"nodejs22.x"},"me-south-1":{"value":"nodejs22.x"},"mx-central-1":{"value":"nodejs22.x"},"sa-east-1":{"value":"nodejs22.x"},"us-east-1":{"value":"nodejs22.x"},"us-east-2":{"value":"nodejs22.x"},"us-gov-east-1":{"value":"nodejs22.x"},"us-gov-west-1":{"value":"nodejs22.x"},"us-iso-east-1":{"value":"nodejs18.x"},"us-iso-west-1":{"value":"nodejs18.x"},"us-isob-east-1":{"value":"nodejs18.x"},"us-isob-west-1":{"value":"nodejs18.x"},"us-west-1":{"value":"nodejs22.x"},"us-west-2":{"value":"nodejs22.x"}}

Pull request has been modified.

Tietew · 2025-10-28T04:17:06Z

@Abogical Updated the snapshot.

Abogical

Thank you!

mergify · 2025-10-28T15:01:48Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-10-28T16:53:58Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Tietew · 2025-10-29T04:19:30Z

@Mergifyio update

mergify · 2025-10-29T04:19:37Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/pr-build.yml without workflows permission

Pull request has been modified.

mergify · 2025-10-29T08:58:53Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Abogical · 2025-10-29T09:05:05Z

@Mergifyio requeue

mergify · 2025-10-29T09:05:13Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-10-29T09:39:19Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-10-29T09:39:34Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

Tietew added 4 commits March 17, 2025 15:15

add FirehoseDeliveryStream

f48a1d3

assesions in integ test

80d697b

update README

ecbdc94

update @deprecated

c4d2f35

github-actions bot added the p2 label Mar 17, 2025

aws-cdk-automation requested a review from a team March 17, 2025 06:40

github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Mar 17, 2025

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 17, 2025

Tietew mentioned this pull request Mar 17, 2025

fix(scheduler-targets-alpha): rename KinesisDataFirehosePutRecord to FirehosePutRecord #33758

Merged

1 task

Merge branch 'main' into events-targets-firehose

c54e832

Tietew added 2 commits March 21, 2025 08:29

Merge branch 'main' into events-targets-firehose

78def45

Merge branch 'main' into events-targets-firehose

286b140

github-actions bot mentioned this pull request Apr 1, 2025

Monthly PR metrics report #33994

Closed

Tietew changed the title ~~fix(events-targets): rename KinesisFirehoseStreamV2 to FirehoseDeliveryStream~~ feat(events-targets): support Amazon Data Firehose target using Firehose's IDeliveryStream May 14, 2025

Tietew added 7 commits May 14, 2025 12:08

Merge branch 'main' into events-targets-firehose

54c88ee

update snapshot (new region)

af84172

Merge branch 'main' into events-targets-firehose

f8b3734

stream -> deliveryStream

2a10da2

fix tests

47f03c4

Merge branch 'main' into events-targets-firehose

7ffeeb4

update snapshot

e566700

Abogical previously requested changes Oct 23, 2025

View reviewed changes

packages/aws-cdk-lib/aws-events-targets/lib/firehose.ts Show resolved Hide resolved

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 23, 2025

Abogical self-assigned this Oct 23, 2025

Abogical self-requested a review October 27, 2025 09:16

Merge branch 'main' into events-targets-firehose

8e9875d

Abogical previously requested changes Oct 27, 2025

View reviewed changes

update snapshot

aba86b9

Abogical previously approved these changes Oct 28, 2025

View reviewed changes

Merge branch 'main' into events-targets-firehose

f4f61f5

Abogical approved these changes Oct 29, 2025

View reviewed changes

Merge branch 'main' into events-targets-firehose

8b10c3a

mergify bot merged commit a374b6b into aws:main Oct 29, 2025
18 of 20 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2025

Tietew deleted the events-targets-firehose branch October 30, 2025 09:32

feat(events-targets): support Amazon Data Firehose target using Firehose's IDeliveryStream #33798

feat(events-targets): support Amazon Data Firehose target using Firehose's IDeliveryStream #33798

Uh oh!

Conversation

Tietew commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

codecov bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aws-cdk-automation commented Jul 29, 2025

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Abogical commented Oct 27, 2025

Uh oh!

mergify bot commented Oct 27, 2025

❌ Mergify doesn't have permission to update

Uh oh!

Abogical left a comment

Choose a reason for hiding this comment

Uh oh!

Tietew commented Oct 28, 2025

Uh oh!

Abogical left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Oct 28, 2025

Uh oh!

mergify bot commented Oct 28, 2025

Uh oh!

Tietew commented Oct 29, 2025

Uh oh!

mergify bot commented Oct 29, 2025

❌ Mergify doesn't have permission to update

Uh oh!

mergify bot commented Oct 29, 2025

Uh oh!

Abogical commented Oct 29, 2025

Uh oh!

mergify bot commented Oct 29, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Oct 29, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(events-targets): support Amazon Data Firehose target using Firehose's `IDeliveryStream` #33798

feat(events-targets): support Amazon Data Firehose target using Firehose's `IDeliveryStream` #33798

Tietew commented Mar 17, 2025 •

edited

Loading

codecov bot commented Mar 17, 2025 •

edited

Loading