Skip to content

Conversation

@IkeNefcy
Copy link
Contributor

@IkeNefcy IkeNefcy commented Mar 16, 2025

Issue

Closes #33795

Reason for this change

filling in missing readme changes from PRs #33360 and #33742

Description of changes

Added the comment wall back in, not sure what happened there.
//////////////////////////////////////////////////////////////////////

Added readme's based on the ff descriptions

* `@aws-cdk/aws-s3:setUniqueReplicationRoleName`
When this feature flag is enabled, a unique role name is specified only when performing cross-account replication.
When disabled, 'CDKReplicationRole' is always specified.
_cdk.json_
```json
{
"context": {
"@aws-cdk/aws-s3:setUniqueReplicationRoleName": true
}
}
```
* `@aws-cdk/pipelines:reduceStageRoleTrustScope`
When this feature flag is enabled, the root account principal will not be added to the trust policy of stage role.
When this feature flag is disabled, it will keep the root account principal in the trust policy.
_cdk.json_
```json
{
"context": {
"@aws-cdk/pipelines:reduceStageRoleTrustScope": true
}
}
```

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 16, 2025 17:53
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Mar 16, 2025
@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (ab6ba09) to head (d1611f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33796   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d1611f7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@IkeNefcy IkeNefcy marked this pull request as ready for review March 16, 2025 18:24
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 16, 2025
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Mar 17, 2025
@QuantumNeuralCoder QuantumNeuralCoder added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 17, 2025
Copy link
Contributor

@QuantumNeuralCoder QuantumNeuralCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes by comparing the 2 PRs listed (one of them is my PR)

@aws-cdk-automation aws-cdk-automation removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Mar 17, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6a57c50 into aws:main Mar 17, 2025
48 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2025
@IkeNefcy IkeNefcy deleted the restoringOrderPart1 branch October 14, 2025 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

effort/medium Medium work item – several days of effort p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cx-api: missing ff readme's

3 participants