Skip to content

chore(ec2): backfill missing enums for ec2 #33642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

chore(ec2): backfill missing enums for ec2 #33642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09bb1e2
chore(ec2): backfill missing enums for ec2
paulhcsun Feb 28, 2025
66af285
Update packages/aws-cdk-lib/aws-ec2/lib/launch-template.ts
Leo10Gama Mar 1, 2025
92ca223
Update packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts
Leo10Gama Mar 1, 2025
4bcba5e
Update packages/aws-cdk-lib/aws-ec2/lib/machine-image/common.ts
Leo10Gama Mar 1, 2025
45cce36
Update packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts
Leo10Gama Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,6 +1481,21 @@ export enum InstanceArchitecture {
* x86-64 architecture
*/
X86_64 = 'x86_64',

/**
* i386 architecture
*/
I386 = 'i386',

/**
* x86-64 architecture for Mac
*/
X86_64_MAC = 'x86_64_mac',

/**
* arm64 architecture for Mac
*/
ARM64_MAC = 'arm64_mac',
Comment on lines +1484 to +1498
Copy link
Member

@godwingrs22 godwingrs22 Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a valid value for the property as per the CFN doc

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-instance.html#cfn-ec2-instance-instancetype

}

/**
Expand Down
5 changes: 5 additions & 0 deletions packages/aws-cdk-lib/aws-ec2/lib/launch-template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ export enum InstanceInitiatedShutdownBehavior {
* The instance will be terminated when it initiates a shutdown.
*/
TERMINATE = 'terminate',

/**
* The instance will hibernate when it initiates a shutdown.
*/
HIBERNATE = 'hibernate',
Copy link
Member

@godwingrs22 godwingrs22 Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a valid value for the property as per the CFN doc

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-launchtemplate-launchtemplatedata.html#cfn-ec2-launchtemplate-launchtemplatedata-instanceinitiatedshutdownbehavior

}

/**
Expand Down
15 changes: 15 additions & 0 deletions packages/aws-cdk-lib/aws-ec2/lib/machine-image/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,21 @@ export enum AmazonLinuxCpuType {
* x86_64 CPU type
*/
X86_64 = 'x86_64',

/**
* i386 CPU type
*/
I386 = 'i386',

/**
* x86-64 CPU type for Mac
*/
X86_64_MAC = 'x86_64_mac',

/**
* arm64 CPU type for Mac
*/
ARM64_MAC = 'arm64_mac',
Comment on lines +166 to +180
Copy link
Member

@godwingrs22 godwingrs22 Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these are valid values for the enum. Couldn't able to find corresponding doc to validate.

}

/**
Expand Down
15 changes: 15 additions & 0 deletions packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,21 @@ export enum VpcEndpointType {
* your route table, used for traffic destined to a supported AWS service.
*/
GATEWAY = 'Gateway',

/**
* Gateway Load Balancer
*/
GATEWAYLOADBALANCER = 'GatewayLoadBalancer',

/**
* Resource
*/
RESOURCE = 'Resource',

/**
* Service Network
*/
SERVICENETWORK = 'ServiceNetwork',
}

/**
Expand Down