Skip to content

Conversation

@kwwendt
Copy link
Contributor

@kwwendt kwwendt commented Feb 25, 2025

Reason for this change

Improved assertion tests for newly added AppSync Event API + Channel namespace constructs. Improved documentation to show no channel namespace is created by default, one must be explicitly defined.

Description of changes

  • Added assertions to the following integration tests:
    • integ.appsync-event-api.ts
    • integ.appsync-eventapi-api-key-auth.ts
    • integ.appsync-eventapi-cognito-auth.ts
    • integ.appsync-eventapi-grants.ts
    • integ.appsync-eventapi-iam-auth.ts
    • integ.appsync-eventapi-lambda-auth.ts

To validate Cognito authorization, I needed to include the following package @aws-sdk/client-cognito-identity-provider which is why yarn.lock is updated in this PR.

  • Added channel namespace usage to all Event API examples in README.md.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Integration tests all run successfully with passed assertion tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Feb 25, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 25, 2025 00:41
@github-actions github-actions bot added the p2 label Feb 25, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@kwwendt kwwendt changed the title fix(aws-appsync): Appsync Event API integration assertion tests fix(appsync): Appsync Event API integration assertion tests Feb 25, 2025
@codecov
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (e07a89c) to head (475f6f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33572   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

Copy link
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you for adding assertions!

@GavinZZ GavinZZ added the pr/do-not-merge This PR should not be merged at this time. label Feb 26, 2025
@GavinZZ GavinZZ added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Feb 26, 2025
@GavinZZ
Copy link
Member

GavinZZ commented Feb 26, 2025

Adding a do-not-merge as pending a review from the AppSec security team.

@kwwendt kwwendt changed the title fix(appsync): Appsync Event API integration assertion tests fix(appsync): appsync Event API integration assertion tests Feb 27, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 27, 2025 16:51

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@GavinZZ GavinZZ removed the pr/do-not-merge This PR should not be merged at this time. label Mar 1, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 475f6f0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6f966a6 into aws:main Mar 2, 2025
20 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2025
@kwwendt kwwendt deleted the appsync-eventapi-integ-assertion-tests branch April 21, 2025 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants