Skip to content

Conversation

@go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Feb 11, 2025

Issue # (if applicable)

Closes #33376

Reason for this change

AWS CodePipeline introduces new build action: ECRBuildAndPublish action.

Description of changes

Add ECRBuildAndPublishAction class that extends Action class to aws-codepipeline-actions module.

Describe any new or updated permissions being added

Description of how you validated changes

Both unit and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2025 07:23
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Feb 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (217d75f) to head (b72e14d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33375   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the feature-request A feature should be added or improved. label Feb 11, 2025
@go-to-k go-to-k changed the title feat(codepipeline-actions): support ECRBuildAndPublish build action feat(codepipeline-actions): support ECRBuildAndPublish action Feb 11, 2025
@go-to-k go-to-k changed the title feat(codepipeline-actions): support ECRBuildAndPublish action feat(codepipeline-actions): support ECRBuildAndPublish action Feb 11, 2025
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Feb 14, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 14, 2025 13:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@go-to-k go-to-k marked this pull request as ready for review February 14, 2025 13:57
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 14, 2025 14:40

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@go-to-k
Copy link
Contributor Author

go-to-k commented Mar 27, 2025

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@go-to-k
Copy link
Contributor Author

go-to-k commented Mar 27, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

@go-to-k
Copy link
Contributor Author

go-to-k commented Mar 27, 2025

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025

refresh

✅ Pull request refreshed

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should update or rebase your pull request manually.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@go-to-k
Copy link
Contributor Author

go-to-k commented Mar 27, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

@go-to-k
Copy link
Contributor Author

go-to-k commented Mar 27, 2025

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025

refresh

✅ Pull request refreshed

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should update or rebase your pull request manually.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@go-to-k
Copy link
Contributor Author

go-to-k commented Mar 27, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

@go-to-k
Copy link
Contributor Author

go-to-k commented Mar 27, 2025

@GavinZZ

Hmmm... I'm not sure what to do.
What should I do in such a case? Shoud I just wait?

@go-to-k
Copy link
Contributor Author

go-to-k commented Apr 1, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 1, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

@go-to-k
Copy link
Contributor Author

go-to-k commented Apr 1, 2025

@GavinZZ Could you please check this situation again?

@GavinZZ
Copy link
Member

GavinZZ commented Apr 1, 2025

Sorry @go-to-k for the late response. I'll handle this PR.

@mergify mergify bot dismissed GavinZZ’s stale review April 1, 2025 21:45

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Apr 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b72e14d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c5cd679 into aws:main Apr 1, 2025
20 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2025
@go-to-k go-to-k deleted the cp-actions-ecr-build-publish branch April 2, 2025 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

codepipeline-actions: support ECRBuildAndPublish action

3 participants