feat(cli): support CloudFormation simplified resource import #32676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe revert later
Co-authored-by: Luca Pizzini <[email protected]>
Co-authored-by: Luca Pizzini <[email protected]>
Co-authored-by: Luca Pizzini <[email protected]>
Co-authored-by: Calvin Combs <[email protected]>
Co-authored-by: Hogan Bobertz <[email protected]> Co-authored-by: Calvin Combs <[email protected]>
kaizencc
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
added
the
pr/needs-cli-test-run
kaizencc
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
kaizencc
added
the
pr-linter/exempt-integ-test
Collaborator
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
kaizencc
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
kaizencc
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
kaizencc
added
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
kaizencc
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
kaizencc
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
kaizencc
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
rix0rrr
approved these changes
Jan 1, 2025
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #28060.
Reason for this change
This feature allows to automatically import exsting resources with the same physical name, such as S3 bucket, DDB table, etc, during a CFn deployment.
Because resource import is a vital feature for CDK users e.g. to refactor a construct tree, cdk migrate, etc, it would benefit many potential users if cdk natively support it.
Description of changes
This PR adds a CLI option --import-exsting-resources: boolean to cdk deploy command and pass it to createChangeSet API call.
Description of how you validated changes
Added a cli integ test.
Checklist
Co-authored-by: Masashi Tomooka [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license