Skip to content

chore(prlint): linter comments every minute on PRs that have many comments #32671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2024
Merged

chore(prlint): linter comments every minute on PRs that have many comments #32671

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76ab00a
chore(prlint): linter comments every minute on PRs that have many com…
kaizencc Dec 27, 2024
399d698
Merge branch 'main' into conroy/fixlinter
mergify[bot] Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tools/@aws-cdk/prlint/lint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ export class PullRequestLinter {
});
}

const comments = await this.client.issues.listComments(this.issueParams);
if (comments.data.find(comment => comment.body?.toLowerCase().includes("exemption request"))) {
const comments = await this.client.paginate(this.client.issues.listComments, this.issueParams);
if (comments.find(comment => comment.body?.toLowerCase().includes("exemption request"))) {
body += '\n\n✅ A exemption request has been requested. Please wait for a maintainer\'s review.';
}
await this.client.issues.createComment({
Expand Down Expand Up @@ -303,17 +303,17 @@ export class PullRequestLinter {
* @returns Existing review, if present
*/
private async findExistingPRLinterReview(): Promise<Review | undefined> {
const reviews = await this.client.pulls.listReviews(this.prParams);
return reviews.data.find((review) => review.user?.login === 'aws-cdk-automation' && review.state !== 'DISMISSED') as Review;
const reviews = await this.client.paginate(this.client.pulls.listReviews, this.prParams);
return reviews.find((review) => review.user?.login === 'aws-cdk-automation' && review.state !== 'DISMISSED') as Review;
}

/**
* Finds existing comment from previous review, if present
* @returns Existing comment, if present
*/
private async findExistingPRLinterComment(): Promise<Comment | undefined> {
const comments = await this.client.issues.listComments(this.issueParams);
return comments.data.find((comment) => comment.user?.login === 'aws-cdk-automation' && comment.body?.startsWith('The pull request linter fails with the following errors:')) as Comment;
const comments = await this.client.paginate(this.client.issues.listComments, this.issueParams);
return comments.find((comment) => comment.user?.login === 'aws-cdk-automation' && comment.body?.startsWith('The pull request linter fails with the following errors:')) as Comment;
}

/**
Expand Down
Loading