fix(opensearch): add I4I and R7GD to list of OpenSearch nodes not requiring EBS volumes

[mazyu36]

Issue # (if applicable)

Closes #32070.
Closes #32138.

Reason for this change

I4I and R7GD instances don't require ebs volumes.
But at the moment, a domain with I4I and R7GD instances cannot be deployed.

Description of changes

Added I4I and R7GD to not requiring EBS volumes instances list.

Describe any new or updated permissions being added

Add unit tests and integ tests.
<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->

Description of how you validated changes

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[nmussy]

It would be nice to refactor these instance type lists and store them in a named constant, to improve readability and maintenance. You could also use their human-friendlier InstanceClass names, something like:

private static readonly UNSUPPORTED_EBS = [
  ec2.InstanceClass.IO3,
  ec2.InstanceClass.MEMORY6_GRAVITON2_NVME_DRIVE,
  // ...
];

// ...
if(isSomeInstanceType(...UNSUPPORTED_EBS) && ebsEnabled) throw

You could also generate the error message using this list, without having to update them both manually:

function formatInstanceTypesList(instanceTypes: string[]): string {
  return instanceTypes.map((type) => type.toUpperCase()).join(', ').replace(/, ([^,]*)$/, ' and $1');
}

throw new Error(`${formatInstanceTypesList(UNSUPPORTED_EBS)} instance types do not support EBS storage volumes.`);

[mazyu36]

Thank you. I took your suggestions into account and tried refactoring the relevant parts for this fix.
As for unrelated parts, I plan to refactor them in a separate PR.

[nmussy]

The domainProps variable seems unnecessary, especially because it has to be typed to get IDE hints instead of inheriting the constructor's signature

Suggested change

	const domainProps: opensearch.DomainProps = {
	removalPolicy: RemovalPolicy.DESTROY,
	version: opensearch.EngineVersion.OPENSEARCH_2_17,
	// specify the instance type that supports instance store
	capacity: {
	multiAzWithStandbyEnabled: false,
	dataNodeInstanceType: instanceType,
	dataNodes: 1,
	},
	// force ebs configuration to be disabled
	ebs: {
	enabled: false,
	},
	};
	new opensearch.Domain(this, `Domain${index + 1}`, domainProps);
	new opensearch.Domain(this, `Domain${index + 1}`, {
	removalPolicy: RemovalPolicy.DESTROY,
	version: opensearch.EngineVersion.OPENSEARCH_2_17,
	// specify the instance type that supports instance store
	capacity: {
	multiAzWithStandbyEnabled: false,
	dataNodeInstanceType: instanceType,
	dataNodes: 1,
	},
	// force ebs configuration to be disabled
	ebs: {
	enabled: false,
	},
	});

[mazyu36]

fixed.

[mazyu36]

I'm not sure whether R3 should be included in unSupportEbsInstanceType because I couldn't find any documentation, and it has already been deprecated.

To avoid breaking changes, I decided to separate unSupportEbsInstanceType and supportInstanceStorageInstanceType in line with the current implementation, just in case.

[nmussy]

You should still be able to deploy previous gen instances to test this, but it probably doesn't matter either way

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (cb985ba) to head (7794ffe).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32592   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files         106      106           
  Lines        6954     6954           
  Branches     1287     1287           
=======================================
  Hits         5601     5601           
  Misses       1175     1175           
  Partials      178      178           

Flag	Coverage Δ
suite.unit	80.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	80.54% <ø> (ø)

[nmussy]

LGTM, thanks for the refactor

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 7794ffe
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.