Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Dec 13, 2024

Reverts #32476

This breaks the build for some reason:


> aws-cdk:package
--
4465 |  
4466 | aws-cdk: <span class='ace_invisible ace_invisible_space ace_invalid'>·</span>[1Gaws-cdk: yarn run v1.22.22
4467 | aws-cdk: <span class='ace_invisible ace_invisible_space ace_invalid'>·</span>[1G$ cdk-package
4468 | aws-cdk: Validating circular imports
4469 | aws-cdk: Validating resources
4470 | aws-cdk: Validating attributions
4471 | aws-cdk: Writing bundle
4472 | aws-cdk: Running sanity test: /tmp/bundle-write-MEtJ7C/bin/cdk --version
4473 | aws-cdk: node:internal/modules/cjs/loader:1143
4474 | aws-cdk:   throw err;
4475 | aws-cdk:   ^
4476 | aws-cdk: Error: Cannot find module '@aws-cdk/cx-api'
4477 | aws-cdk: Require stack:
4478 | aws-cdk: - /tmp/bundle-write-MEtJ7C/lib/cli.js
4479 | aws-cdk: - /tmp/bundle-write-MEtJ7C/bin/cdk
4480 | aws-cdk:     at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
4481 | aws-cdk:     at Module._load (node:internal/modules/cjs/loader:981:27)
4482 | aws-cdk:     at Module.require (node:internal/modules/cjs/loader:1231:19)
4483 | aws-cdk:     at require (node:internal/modules/helpers:177:18)
4484 | aws-cdk:     at Object.<anonymous> (/tmp/bundle-write-MEtJ7C/lib/cli.ts:1:1)
4485 | aws-cdk:     at Module._compile (node:internal/modules/cjs/loader:1364:14)
4486 | aws-cdk:     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
4487 | aws-cdk:     at Module.load (node:internal/modules/cjs/loader:1203:32)
4488 | aws-cdk:     at Module._load (node:internal/modules/cjs/loader:1019:12)
4489 | aws-cdk:     at Module.require (node:internal/modules/cjs/loader:1231:19) {
4490 | aws-cdk:   code: 'MODULE_NOT_FOUND',
4491 | aws-cdk:   requireStack: [
4492 | aws-cdk:     '/tmp/bundle-write-MEtJ7C/lib/cli.js',
4493 | aws-cdk:     '/tmp/bundle-write-MEtJ7C/bin/cdk'
4494 | aws-cdk:   ]
4495 | aws-cdk: }
4496 | aws-cdk: Node.js v18.20.5
4497 | aws-cdk: Error: Command failed: /tmp/bundle-write-MEtJ7C/bin/cdk --version
4498 | aws-cdk: Package failed. Total time (15.9s)

@mrgrain mrgrain requested a review from a team as a code owner December 13, 2024 19:20
@github-actions github-actions bot added the p2 label Dec 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 13, 2024 19:20
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 13, 2024
@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (283edd6) to head (e3c9eeb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32518   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         107      107           
  Lines        7161     7161           
  Branches     1320     1320           
=======================================
  Hits         5633     5633           
  Misses       1343     1343           
  Partials      185      185           
Flag Coverage Δ
suite.unit 78.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.66% <ø> (ø)

@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Dec 13, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e3c9eeb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mrgrain
Copy link
Contributor Author

mrgrain commented Dec 13, 2024

closed in favor of #32514

@mrgrain mrgrain closed this Dec 13, 2024
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
@mrgrain mrgrain deleted the revert-32476-huijbers/no-js-file branch January 23, 2025 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/do-not-merge This PR should not be merged at this time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants