Skip to content

Conversation

@antarasi
Copy link

@antarasi antarasi commented Dec 7, 2024

Issue # (if applicable)

Closes #.

Reason for this change

ra3.large is a supported node type as per the CFN documentation, but missing in the type definition:

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-redshift-cluster.html#cfn-redshift-cluster-nodetype

Description of changes

Extended NodeType enum with the missing entry

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 7, 2024 00:37
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Dec 7, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@antarasi antarasi changed the title Added a missing NodeType to Redshift cluster.ts fix: Added a missing NodeType to Redshift cluster.ts Dec 7, 2024
@antarasi antarasi changed the title fix: Added a missing NodeType to Redshift cluster.ts fix: added a missing NodeType to Redshift cluster.ts Dec 7, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@gracelu0
Copy link
Contributor

gracelu0 commented Dec 7, 2024

Hi @antarasi , I just approved this PR which seems to address the same issue: #31637 so I'll close this one to avoid duplicated efforts. Appreciate the contribution though! :)

@gracelu0 gracelu0 closed this Dec 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 921e9af
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@antarasi antarasi deleted the patch-1 branch December 7, 2024 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants