Skip to content

Conversation

@BenChaimberg
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license

@BenChaimberg BenChaimberg marked this pull request as ready for review June 26, 2021 00:26
@BenChaimberg BenChaimberg requested a review from a team June 26, 2021 00:26
@mergify mergify bot dismissed rix0rrr’s stale review July 6, 2021 21:55

Pull request has been modified.

@rix0rrr rix0rrr added status/api-approved API Bar Raiser signed-off the API of this RFC and removed status/api-approved API Bar Raiser signed-off the API of this RFC pr/do-not-merge Let mergify know not to auto merge labels Jul 8, 2021
Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@BenChaimberg BenChaimberg merged commit 068a2cb into master Jul 20, 2021
@BenChaimberg BenChaimberg deleted the chaimber/firehose-l2 branch July 20, 2021 00:51
mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Jul 23, 2021
#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: #15505 and the RFC: aws/aws-cdk-rfcs#342 

closes #10810, #15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
aws#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: aws#15505 and the RFC: aws/aws-cdk-rfcs#342 

closes aws#10810, aws#15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
aws#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: aws#15505 and the RFC: aws/aws-cdk-rfcs#342 

closes aws#10810, aws#15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit to cdklabs/decdk that referenced this pull request Jan 18, 2022
…n (#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: aws/aws-cdk#15505 and the RFC: aws/aws-cdk-rfcs#342 

closes #10810, #15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/api-approved API Bar Raiser signed-off the API of this RFC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants