Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 9, 2025

This PR adds a step to the codecov workflow that resets all coverage thresholds to empty objects before running tests. This ensures that the codecov job never fails due to coverage thresholds not being met, allowing it to simply collect and report coverage data to codecov.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label May 9, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 9, 2025 14:05
@mrgrain mrgrain disabled auto-merge May 9, 2025 14:07
@mrgrain mrgrain force-pushed the mrgrain/fix/codecov/prevent-threshold-failures branch from 0496ffa to 7c2d4ec Compare May 9, 2025 15:16
@mrgrain mrgrain temporarily deployed to integ-approval May 9, 2025 15:16 — with GitHub Actions Inactive
@mrgrain mrgrain enabled auto-merge May 9, 2025 15:25
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.78%. Comparing base (860c229) to head (4e69597).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   79.17%   79.78%   +0.60%     
==========================================
  Files          54       54              
  Lines        6914     6914              
  Branches      774      779       +5     
==========================================
+ Hits         5474     5516      +42     
+ Misses       1422     1378      -44     
- Partials       18       20       +2     
Flag Coverage Δ
suite.unit 79.78% <ø> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain temporarily deployed to integ-approval May 9, 2025 22:30 — with GitHub Actions Inactive
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label May 11, 2025
@mrgrain mrgrain closed this May 11, 2025
auto-merge was automatically disabled May 11, 2025 11:36

Pull request was closed

@mrgrain mrgrain reopened this May 11, 2025
@mrgrain mrgrain added this pull request to the merge queue May 11, 2025
Merged via the queue into main with commit 52457cf May 11, 2025
28 of 64 checks passed
@mrgrain mrgrain deleted the mrgrain/fix/codecov/prevent-threshold-failures branch May 11, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants