Skip to content

👕 resolve lint errors in index.py #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

👕 resolve lint errors in index.py #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions code/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"""
def publishToSNS(message, topicARN):
logger.info("Publish to SNS topic %s",topicARN)
snsResponse = snsClient.publish(
snsClient.publish(
TopicArn=topicARN,
Message=json.dumps(message),
Subject='Publishing SNS message to invoke lambda again..'
Expand Down Expand Up @@ -62,8 +62,9 @@ def checkContainerInstanceTaskStatus(Ec2InstanceId):
# Get list of container instance IDs from the clusterName
paginator = ecsClient.get_paginator('list_container_instances')
clusterListPages = paginator.paginate(cluster=clusterName)
containerListResp = None
for containerListResp in clusterListPages:
containerDetResp = ecsClient.describe_container_instances(cluster=clusterName, containerInstances=clusterListResp[
containerDetResp = ecsClient.describe_container_instances(cluster=clusterName, containerInstances=containerListResp[
'containerInstanceArns'])
logger.debug("describe container instances response %s",containerDetResp)

Expand All @@ -83,7 +84,7 @@ def checkContainerInstanceTaskStatus(Ec2InstanceId):
else:
# Make ECS API call to set the container status to DRAINING
logger.info("Make ECS API call to set the container status to DRAINING...")
ecsResponse = ecsClient.update_container_instances_state(cluster=clusterName,containerInstances=[containerInstanceId],status='DRAINING')
ecsClient.update_container_instances_state(cluster=clusterName,containerInstances=[containerInstanceId],status='DRAINING')
# When you set instance state to draining, append the containerInstanceID to the message as well
tmpMsgAppend = {"containerInstanceId": containerInstanceId}
break
Expand Down Expand Up @@ -117,10 +118,9 @@ def lambda_handler(event, context):
snsArn = event['Records'][0]['EventSubscriptionArn']
TopicArn = event['Records'][0]['Sns']['TopicArn']

lifecyclehookname = None
lifecycleHookName = None
clusterName = None
tmpMsgAppend = None
completeHook = 0

logger.info("Lambda received the event %s",event)
logger.debug("records: %s",event['Records'][0])
Expand Down Expand Up @@ -173,7 +173,6 @@ def lambda_handler(event, context):
logger.debug("msgResponse %s and time is %s",msgResponse, datetime.datetime)
# If tasks are NOT running...
elif tasksRunning == 0:
completeHook = 1
logger.debug("Setting lifecycle to complete;No tasks are running on instance, completing lifecycle action....")

try:
Expand Down