fix(event-handler): pass event, context and request objects into handler #4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
boring-cyborg
bot
added
event-handler
svozza
changed the title
svozza
force-pushed
the
event-handler/request-event-context
branch
from
491fe9f to
a6df09c
Compare
dreamorosi
reviewed
Aug 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This begins the work for for repsonse handling piece of the REST API event handler. As with other event handlers we need to pass the raw event and the lambda context as option into the handler. We will also pass a
Requestobject in, should users prefer to use this web standard when defining their handlers.Changes
RouteHandlerandErrorHandlerto support passing the new parameters in.RouteHandlerfromanytoResponse | JSONObjectAPIGatewayProxyEventtraceandconnectHTTP methods [see note]Note
When attempting to create a
Requestobject for thetraceandconnecttests, I received an error from the constructor saying they were not supported. On investigation I discovered that these methods are forbidden by the Fetch specification due to security concerns. I do not think we should support these methods in the event handler so have removed them.Issue number: closes #4340
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.