Skip to content

fix(deps-dev): remove jmespath due to dev deps conflict #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2022
Merged

fix(deps-dev): remove jmespath due to dev deps conflict #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f201991
fix(deps-dev): Remove jmespath due to errors
sthulb Apr 21, 2022
0e49b31
Add a comment for JMESPath
sthulb Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,12 @@ python = "^3.6.2"
aws-xray-sdk = "^2.8.0"
fastjsonschema = "^2.14.5"
boto3 = "^1.18"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here so we review jmespath state after 3.6 Lambda deprecation?

I think we can trust boto to not drop jmespath given how crucial it is for them, but I wanna be conservative as (1) it doesn't add any extra bytes at runtime, and (2) jmespath hasn't been updated in years

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this we can merge it!

jmespath = [
{ version = "<=0.10.0", python = "3.6" },
{ version = "^1.0.0", python = "^3.7" }
]
pydantic = {version = "^1.8.2", optional = true }
email-validator = {version = "*", optional = true }

[tool.poetry.dev-dependencies]
# 2022-04-21: jmespath was removed, to be re-added once we drop python 3.6.
# issue #1148
coverage = {extras = ["toml"], version = "^6.2"}
pytest = "^7.0.1"
black = "^21.12b0"
Expand Down