Fix removing gRPC in Dockerfile #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
approved these changes
Apr 22, 2024
thpierce
added a commit
that referenced
this pull request
Apr 22, 2024
The previous fix (#172) was not working as deleting the files after installation caused dangling dependencies - the instrumentation expected a dependency, but it was not found, causing instrumentation to fail. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thpierce
added a commit
that referenced
this pull request
Apr 22, 2024
We are installing using `pip install --target`. To fix this we must set PYTHONPATH so pip can find and uninstall these packages. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thpierce
added a commit
that referenced
this pull request
Apr 22, 2024
The previous fix (#172) was not working as deleting the files after installation caused dangling dependencies - the instrumentation expected a dependency, but it was not found, causing instrumentation to fail. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are installing using
pip install --target. To fix this we must set PYTHONPATH so pip can find and uninstall these packages.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.