Skip to content

Update replacement_values for new canary regions #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2023
Merged

Update replacement_values for new canary regions #239

merged 2 commits into from
Apr 12, 2023

Conversation

rd-pong
Copy link
Contributor

@rd-pong rd-pong commented Apr 12, 2023

Issue #, if available:

Description of changes:
Update replacement_values for new canary regions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from jsitu777 April 12, 2023 17:29
@ack-prow ack-prow bot added the approved label Apr 12, 2023
@ananth102
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@ack-prow
Copy link

ack-prow bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ananth102, rd-pong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow
Copy link

ack-prow bot commented Apr 12, 2023

@rd-pong: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
sagemaker-kind-e2e 9a04ec1 link true /test sagemaker-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ananth102
Copy link
Member

/retest

@rd-pong rd-pong merged commit 57cedf2 into aws-controllers-k8s:main Apr 12, 2023
@rd-pong rd-pong deleted the expand_region branch April 13, 2023 00:01
rd-pong added a commit to rd-pong/sagemaker-controller that referenced this pull request Apr 18, 2023
@rd-pong
Update replacement_values for new canary regions (aws-controllers-k8s…
20cb787 
…#239)

Issue #, if available:

Description of changes:
Update replacement_values for new canary regions

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@surajkota surajkota Awaiting requested review from surajkota

@ryansteakley ryansteakley Awaiting requested review from ryansteakley

@jsitu777 jsitu777 Awaiting requested review from jsitu777

Assignees

@ananth102 ananth102

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rd-pong @ananth102