Skip to content

Conversation

codekow
Copy link

@codekow codekow commented Jan 12, 2023

Issue #, if available:

Description of changes:

Adjust the label selector for pods that avoids issues when multiple operators are deployed.

The selector controller is not sufficient for expected operation for the service or automated selection.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot
Copy link
Collaborator

ack-bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: codekow
To complete the pull request process, please assign vijtrip2 after the PR has been reviewed.
You can assign the PR to them by writing /assign @vijtrip2 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 12, 2023
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 12, 2023

Hi @codekow. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codekow thanks for your contribution! All of these config files, however, are generated by ACK's code generator for all the controllers here:

https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/config/controller/deployment.yaml.tpl

So, in order to add these labels, you would need to add to that template and then regenerate the controller using make build-controller SERVICE=s3 from a checkout of the code-generator repository.

Fancy giving that PR to the code-generator repository a try? I can help walk you through things if you get lost.

Best,
-jay

@codekow
Copy link
Author

codekow commented Jan 12, 2023

Thanks @jaypipes - I figured it would be more interesting than this. I'll see what I can do. 😄

@RedbackThomson
Copy link
Contributor

Going to just close this because we don't want to merge anything that might be overwritten

ack-bot pushed a commit to aws-controllers-k8s/code-generator that referenced this pull request Jan 27, 2023
Issue #, if available: [#1632](aws-controllers-k8s/community#1632)

Description of changes:

Improve label selection for service and deployment association with pods. When multiple operators are deployed you may get inconsistent results on the service.

Related [s3-controller/pull/94](aws-controllers-k8s/s3-controller#94)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants