Better NPE handling of updateComputeConfig

[kunhwiko]

Issue #, if available:
N/A

Description of changes:
updateComputeConfig seems to currently be susceptible to NPE errors, especially when the user isn't using EKS Auto Mode.

The function is executed when any one of these conditions are met:

• delta.DifferentAt("Spec.ComputeConfig")
• delta.DifferentAt("Spec.StorageConfig")
• delta.DifferentAt("Spec.KubernetesNetworkConfig")

There is no guarantee that all 3 fields are fully populated, so we may need to gracefully handle some inputs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kunhwiko
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ack-prow]

Hi @kunhwiko. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kunhwiko]

So updateComputeConfig seems to be triggered when one of these conditions are met:

• delta.DifferentAt("Spec.ComputeConfig")
• delta.DifferentAt("Spec.StorageConfig")
• delta.DifferentAt("Spec.KubernetesNetworkConfig")

As an example here, users that aren't using EKS auto mode might be using Spec.KubernetesNetworkConfig but are likely to leave Spec.ComputeConfig and Spec.StorageConfig empty. This leads to a NilPointerException.

[a-hilaly]

/ok-to-test

[kunhwiko]

One thing that I noticed is even with an empty elasticloadbalancing input:

spec:
  accessConfig:
    authenticationMode: CONFIG_MAP
  kubernetesNetworkConfig:
    ipFamily: ipv4
    serviceIPv4CIDR: 172.20.0.0/14

The AWS API sometimes is returning this field initialized with some default:

aws eks describe-cluster --name <cluster-name>

"kubernetesNetworkConfig": {
    "serviceIpv4Cidr": "172.20.0.0/14",
    "ipFamily": "ipv4",
    "elasticLoadBalancing": {
        "enabled": false
    }
},

This is causing a delta to always occur between desired (i.e. user input) / latest (i.e. fetched from AWS). Anyways either nil or false here should indicate we don't want EKS auto mode to be turned on.

[kunhwiko]

Something wrong with my local setup..?

[a-hilaly]

You just need to pull the git tags

[kunhwiko]

@a-hilaly That did it :D Any tips for the go version as well?...

[kunhwiko]

/test eks-kind-e2e

[ack-prow]

@kunhwiko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
eks-verify-attribution	6569a97	link	false	/test eks-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.