Skip to content

build-controller-release.sh should also optionally create the OLM bundle on disk to be committed #972

@komish

Description

@komish

Is your feature request related to a problem?

No

Describe the solution you'd like

When build-controller-release.sh is called, the logic should go ahead and build all OLM assets. It's currently building most of them, but not actually building the bundle to commit to a repository.

The OLM workflow that already exists is conditional: https://github.com/aws-controllers-k8s/code-generator/blob/main/scripts/build-controller-release.sh#L241-L255.

We probably just want to extend this so that it also runs olm-create-bundle.sh with the proper inputs.

Describe alternatives you've considered

Doing this separately would also work, but I can't see a reason why wouldn't do it since we're already generating additional things conditionally. It also makes sense, considering a bundle represents a version, and the build-controller-release.sh gets tagged as a release here on Github.

Additional Info

As an example, something like this being added in this block would probably accomplish this. Note that I this strips out the v from the version tag.

    OLM_RELEASE_VERSION=$(echo $RELEASE_VERSION | tr -d "v")
    $SCRIPTS_DIR/olm-create-bundle.sh "$SERVICE" "$OLM_RELEASE_VERSION"

A PR that closes this would also need to account for the case where the user has no provided a release tag - the default value for RELEASE_VERSION (here) would not work with the above example.

Metadata

Metadata

Assignees

Labels

kind/enhancementCategorizes issue or PR as related to existing feature enhancements.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions