Skip to content

[s3] sdkFind need to make extra API Calls to retrieve Bucket spec fields #798

@a-hilaly

Description

@a-hilaly

I’ve been debugging the s3 controller and it looks like we have a bug (some missing API calls) in the generated resourceManager methods , more precisely in the resourceManager.sdkFind function

The ListBuckets API call only returns bucket names, which causes the sdkFind to merge data from the “latest” state, hence the reconciler doesn’t detect any changes. Code bloc: https://github.com/A-Hilaly/s3-controller/blob/main/pkg/resource/bucket/sdk.go#L63-L79

We need to make extra API GET call for each of the s3 bucket properties like ACL for example https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketAcl.html

/priority important-soon

Metadata

Metadata

Labels

kind/bugCategorizes issue or PR as related to a bug.priority/backlogHigher priority than priority/awaiting-more-evidence.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions