generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 272
Closed
Labels
area/runtimeIssues or PRs as related to controller runtime, common reconciliation logic, etcIssues or PRs as related to controller runtime, common reconciliation logic, etcgood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
currently our controllers are lacking essential /healthz
and /readyz
endpoints for monitoring service health and readiness. To address this, we can utilize controller-runtime
(healthz and readyz libraries).
We will also need necessary to add configurations for deployment manifests and helm charts readinessProbe
and livenessProbe.
.
Changes needs to be added to the code-generator main.go.tpl
and should be as easy as:
if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
setupLog.Error(err, "unable to set up health check")
os.Exit(1)
}
if err := mgr.AddReadyzCheck("readyz", healthz.Ping); err != nil {
setupLog.Error(err, "unable to set up ready check")
os.Exit(1)
}
gecube
Metadata
Metadata
Assignees
Labels
area/runtimeIssues or PRs as related to controller runtime, common reconciliation logic, etcIssues or PRs as related to controller runtime, common reconciliation logic, etcgood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.