Add a new generator config to change PrinterColumn sort function
#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE to reviewers: This branch need to be rebased after #82 merge. |
ack-bot
added
the
do-not-merge/hold
a-hilaly
force-pushed
the
resource-print-config
branch
3 times, most recently
from
5e63d21 to
60f4bed
Compare
Initially we used to have one config field under "is_printable" under `ackconfig.FieldConfig` to instruct the code generator to generate kubebuilder marker comments in order to include the field in `kubectl get` response. Time passed and we are in a situation where want to tune more the way we print these fields and extend the `kubebuilder:printcolumns` comment markers to include options like `priority`, `order` and default columns. This patch reworks the field configuration structure and prepare the laying ground for future print config fields. This patch will simplify the realization of the following issues: * aws-controllers-k8s/community#821 * aws-controllers-k8s/community#822 * aws-controllers-k8s/community#823
This patch introduce a new generator configuration under resource
configuration, mainly to tune the `kubebuilder:printcolumn` marker
comments generation.
More precisely we add `PrintConfig` struct that contains one field
called `OrderBy` used to intruct the code generator how to sort the
`kubebuilder:printcolumn` marker comments.
e.g configuration:
```yaml
resources:
Deployment:
print:
order_by: JSONPath
```
a-hilaly
force-pushed
the
resource-print-config
branch
from
60f4bed to
c6284bb
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue aws-controllers-k8s/community#823
This patch introduce a new generator configuration under resource
configuration, mainly to tune the
kubebuilder:printcolumnmarkercomments generation.
More precisely we add
PrintConfigstruct that contains one fieldcalled
OrderByused to intruct the code generator how to sort thekubebuilder:printcolumnmarker comments.e.g configuration:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.