Skip to content

Conversation

vijtrip2
Copy link
Contributor

@vijtrip2 vijtrip2 commented Jun 3, 2021

Description of changes:
Add metrics-service.yaml to helm template files.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vijtrip2 vijtrip2 self-assigned this Jun 3, 2021
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@a-hilaly
Copy link
Member

a-hilaly commented Jun 3, 2021

/approve
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 79fe5ae into aws-controllers-k8s:main Jun 3, 2021
@vijtrip2 vijtrip2 deleted the metrics-service branch June 3, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants