Skip to content

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Jun 2, 2021

Issue N/A

In some CRDs like GlobalTable adding a is_printable: true to the GlobalTableStatus causes kubectl get to print very large/redundant column names.

Description of changes:

  • This patch adds a new config to allow overriding kubebuilder printcolumn:name
  • Adds metav1.Time to the acceptableColumnMap

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This feature will allow us to generate CRDs with less verbose column
names.
@a-hilaly a-hilaly requested a review from RedbackThomson June 2, 2021 21:15
@ack-bot ack-bot requested review from jaypipes and vijtrip2 June 2, 2021 21:15
@RedbackThomson
Copy link
Contributor

Hmm I wish I had the foresight to add this initially, because I'd probably have made the config a struct containing the boolean and the string - rather than them both being on the parent resource level. Regardless, without breaking backwards compatibility, this is good.

/approve

@a-hilaly
Copy link
Member Author

a-hilaly commented Jun 2, 2021

Hmm I wish I had the foresight to add this initially, because I'd probably have made the config a struct containing the boolean and the string - rather than them both being on the parent resource level. Regardless, without breaking backwards compatibility, this is good.

Agreed. I hesitated to introduce a struct config for it.. but as you said it will break the compatibility .. maybe one day a generator config v2 :)

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Amine. :)

@jaypipes
Copy link
Collaborator

jaypipes commented Jun 3, 2021

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson,jaypipes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit e517724 into aws-controllers-k8s:main Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants