Add a new operation config to override the SetOutput wrapper field
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
reviewed
Jun 14, 2021
pkg/generate/testdata/models/apis/dynamodb/0000-00-00/generator.yaml
Outdated
Show resolved
Hide resolved
a-hilaly
force-pushed
the
config/set_output_wrapper_field_path
branch
2 times, most recently
from
d018804 to
153df1d
Compare
jaypipes
reviewed
Jun 14, 2021
In some AWS APIs `Describe` operations output contains the wanted information in a wrapper field like `TableDescription` and `GlobalTableDescription` ... However in some other APIs for the same operation type, the wanted information is wrapped in different nested object, like `BackupDescription.BackupDetails` for example. This patch adds a new operation configuration that instructs the code-generator to use a specific field path, in order to find the struct that contains the information we want to set the output from.
a-hilaly
force-pushed
the
config/set_output_wrapper_field_path
branch
from
153df1d to
42c735f
Compare
jaypipes
approved these changes
Jun 15, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue N/A
In some AWS APIs
Describeoperations output contains thewanted information in a wrapper field like
TableDescriptionandGlobalTableDescription... However in some other APIs for the sameoperation type, the wanted information is wrapped in different nested
object, like
BackupDescription.BackupDetailsfor example.Description of changes:
This patch adds a new operation configuration that instructs the
code-generator to use a specific field path, in order to find the
struct that contains the information we want to set the output from.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.