Allow zero and negative values for generated float32 bounds check #595
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. | ||
|
There was a problem hiding this comment. Had to use a new file since the existing |
||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"). You may | ||
| // not use this file except in compliance with the License. A copy of the | ||
| // License is located at | ||
| // | ||
| // http://aws.amazon.com/apache2.0/ | ||
| // | ||
| // or in the "license" file accompanying this file. This file is distributed | ||
| // on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| // express or implied. See the License for the specific language governing | ||
| // permissions and limitations under the License. | ||
|
|
||
| package code | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| awssdkmodel "github.com/aws-controllers-k8s/code-generator/pkg/api" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestSetSDKForScalar(t *testing.T) { | ||
| assert := assert.New(t) | ||
|
|
||
| testCases := []struct { | ||
| name string | ||
| targetFieldName string | ||
| targetVarName string | ||
| targetVarType string | ||
| sourceFieldPath string | ||
| sourceVarName string | ||
| isListMember bool | ||
| shapeRef *awssdkmodel.ShapeRef | ||
| indentLevel int | ||
| expected string | ||
| }{ | ||
| { | ||
| name: "string scalar", | ||
| targetFieldName: "BucketName", | ||
| targetVarName: "res", | ||
| targetVarType: "structure", | ||
| sourceFieldPath: "Name", | ||
| sourceVarName: "ko.Spec.Name", | ||
| isListMember: false, | ||
| shapeRef: &awssdkmodel.ShapeRef{ | ||
| Shape: &awssdkmodel.Shape{ | ||
| Type: "string", | ||
| }, | ||
| }, | ||
| indentLevel: 1, | ||
| expected: "\tres.BucketName = ko.Spec.Name\n", | ||
| }, | ||
| { | ||
| name: "boolean scalar", | ||
| targetFieldName: "Enabled", | ||
| targetVarName: "res", | ||
| targetVarType: "structure", | ||
| sourceFieldPath: "Enabled", | ||
| sourceVarName: "ko.Spec.Enabled", | ||
| isListMember: false, | ||
| shapeRef: &awssdkmodel.ShapeRef{ | ||
| Shape: &awssdkmodel.Shape{ | ||
| Type: "boolean", | ||
| }, | ||
| }, | ||
| indentLevel: 1, | ||
| expected: "\tres.Enabled = ko.Spec.Enabled\n", | ||
| }, | ||
| { | ||
| name: "integer scalar", | ||
| targetFieldName: "MaxKeys", | ||
| targetVarName: "res", | ||
| targetVarType: "structure", | ||
| sourceFieldPath: "MaxKeys", | ||
| sourceVarName: "ko.Spec.MaxKeys", | ||
| isListMember: false, | ||
| shapeRef: &awssdkmodel.ShapeRef{ | ||
| Shape: &awssdkmodel.Shape{ | ||
| Type: "integer", | ||
| }, | ||
| }, | ||
| indentLevel: 1, | ||
| expected: ` Copy0 := *ko.Spec.MaxKeys | ||
| if Copy0 > math.MaxInt32 || Copy0 < math.MinInt32 { | ||
| return nil, fmt.Errorf("error: field is of type int32") | ||
| } | ||
| Copy := int32(Copy0) | ||
| res.MaxKeys = &Copy | ||
| `, | ||
| }, | ||
| { | ||
| name: "float scalar", | ||
| targetFieldName: "Temperature", | ||
| targetVarName: "res", | ||
| targetVarType: "structure", | ||
| sourceFieldPath: "Temperature", | ||
| sourceVarName: "ko.Spec.Temperature", | ||
| isListMember: false, | ||
| shapeRef: &awssdkmodel.ShapeRef{ | ||
| Shape: &awssdkmodel.Shape{ | ||
| Type: "float", | ||
| }, | ||
| }, | ||
| indentLevel: 1, | ||
| expected: ` Copy0 := *ko.Spec.Temperature | ||
| if Copy0 > math.MaxFloat32 || Copy0 < -math.MaxFloat32 || (Copy0 < math.SmallestNonzeroFloat32 && !(Copy0 <= 0)) || (Copy0 > -math.SmallestNonzeroFloat32 && !(Copy0 >= 0)) { | ||
| return nil, fmt.Errorf("error: field is of type float32") | ||
| } | ||
| Copy := float32(Copy0) | ||
| res.Temperature = &Copy | ||
| `, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| result := setSDKForScalar( | ||
| tc.targetFieldName, | ||
| tc.targetVarName, | ||
| tc.targetVarType, | ||
| tc.sourceFieldPath, | ||
| tc.sourceVarName, | ||
| tc.isListMember, | ||
| tc.shapeRef, | ||
| tc.indentLevel, | ||
| ) | ||
|
|
||
| assert.Equal(tc.expected, result, "setSDKForScalar() did not return expected result for %s", tc.name) | ||
| }) | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.