Skip to content

Conversation

knottnt
Copy link
Contributor

@knottnt knottnt commented May 19, 2025

Description of changes:

  • Update BadDefaultsAssignment map to include AmazonBedrockAgentBuildTimeLambda.StorageDays to fix missing pointer operations

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 May 19, 2025 03:23
@ack-prow ack-prow bot added the approved label May 19, 2025
@knottnt
Copy link
Contributor Author

knottnt commented May 19, 2025

/retest

- Add AmazonBedrockAgentBuildTimeLambda.StorageDays to BadDefaultsAssignment.
@knottnt knottnt force-pushed the remove-defaults-storage-days branch from b0f24aa to 60e029c Compare May 19, 2025 16:56
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
Copy link

ack-prow bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knottnt
Copy link
Contributor Author

knottnt commented May 19, 2025

/test ec2-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented May 19, 2025

/retest

Copy link

ack-prow bot commented May 19, 2025

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 60e029c link false /test verify-attribution
s3-olm-test 60e029c link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit f201cff into aws-controllers-k8s:main May 19, 2025
17 of 19 checks passed
@knottnt knottnt deleted the remove-defaults-storage-days branch May 19, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants