Skip to content

Conversation

eadasiak
Copy link
Contributor

Issue #, if available: N/A, but related to aws-controllers-k8s/runtime#151

Description of changes: Adds optional support for feature gates in Helm templates. A top-level key of featureGates has been added to the default values file template, and the optional command-line argument has been appended to the deployment template.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler July 16, 2024 22:55
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 16, 2024
Copy link

ack-prow bot commented Jul 16, 2024

Hi @eadasiak. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@acornett21
Copy link
Contributor

I'm not sure if the intent is two PR's, one for helm and one for manifests, but my personal preference is to see any flags added to the runtime, to be in one PR in the code-gen for all deployment types.

@michaelhtm
Copy link
Member

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2024
@a-hilaly
Copy link
Member

/retest

@acornett21
Copy link
Contributor

acornett21 commented Jul 19, 2024

All tests fail for the same reason

Error: INSTALLATION FAILED: parse error at (apigatewayv2-chart/templates/deployment.yaml:199): unexpected EOF

so whatever is rendered out for the deployment at line 199 is incorrect.

@eadasiak
Copy link
Contributor Author

I think I see the issue -- an artifact from local testing. Will submit a revision in just a sec...

@eadasiak eadasiak changed the title add feature flag support in Helm templates add feature gates support in Helm templates Jul 24, 2024
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @eadasiak !!

Tested locally with a dry run helm using:

featureGates:
  ReadOnlyResources: true
  FeatureXYZ: false

Works like a charm~

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the approved label Jul 24, 2024
@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
Copy link

ack-prow bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, eadasiak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit e8ec3d0 into aws-controllers-k8s:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants