-
Notifications
You must be signed in to change notification settings - Fork 226
add feature gates support in Helm templates #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @eadasiak. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm not sure if the intent is two PR's, one for helm and one for manifests, but my personal preference is to see any flags added to the runtime, to be in one PR in the code-gen for all deployment types. |
/ok-to-test |
/retest |
All tests fail for the same reason
so whatever is rendered out for the deployment at line 199 is incorrect. |
I think I see the issue -- an artifact from local testing. Will submit a revision in just a sec... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @eadasiak !!
Tested locally with a dry run helm using:
featureGates:
ReadOnlyResources: true
FeatureXYZ: false
Works like a charm~
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, eadasiak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: N/A, but related to aws-controllers-k8s/runtime#151
Description of changes: Adds optional support for feature gates in Helm templates. A top-level key of
featureGates
has been added to the default values file template, and the optional command-line argument has been appended to the deployment template.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.