Simplify controllers local build system #509
Conversation
3 years ago we added a mechanism to build controllers using local module files for both `ack-generate`, controller binaries and container images. However, those turned out to be very complex to manage and more importantly to maintain... the only use case we've seen over the years is the need to build a controller using a local runtime repository... Now that we want to start running e2e tests against runtime repositories, we need a simplified way to build controller images using the local runtime repository, only! This patch removes all the never-used tooling around `go.local.mod` and keeps `local-build-controller-image` for prow testing purposes. Signed-off-by: Amine Hilaly <[email protected]>
|
/test all |
1 similar comment
|
/test all |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test |
|
@a-hilaly: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
9 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
3 years ago we added a mechanism to build controllers using local module
files for both
ack-generate, controller binaries and container images.However, those turned out to be very complex to manage and more
importantly to maintain... the only use case we've seen over the years
is the need to build a controller using a local runtime repository...
Now that we want to start running e2e tests against runtime
repositories, we need a simplified way to build controller images using
the local runtime repository, only!
This patch removes all the never-used tooling around
go.local.modandkeeps
local-build-controller-imagefor prow testing purposes.Signed-off-by: Amine Hilaly [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.