Skip to content

(fix) enable custom names for service accounts #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2023
Merged

(fix) enable custom names for service accounts #468

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d368849
(fix) enable custom names for service accounts
therealpandey Sep 14, 2023
cc5b417
(fix) put the intended helm config inside {{}}
therealpandey Sep 14, 2023
a395d67
(fix) try escaping service-account.name
therealpandey Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/helm/templates/leader-election-role-binding.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ roleRef:
name: {{.ServicePackageName}}-leader-election-role
subjects:
- kind: ServiceAccount
name: {{.ServiceAccountName}}
name: {{ "{{ include "service-account.name" . }}" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to prepend an \ for the helm brackets. I still get confused with this templinception..

Suggested change
name: {{ "{{ include "service-account.name" . }}" }}
name: {{ "{{ include \"service-account.name\" . }}" }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @grandwizard28

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha, what a coincidence, I just pushed the same patch!

namespace: {{ "{{ .Release.Namespace }}" }}
{{- "{{- end }}" }}