Lint all scripts with shellcheck #392
Conversation
There was a problem hiding this comment.
Nice one @RedbackThomson. I wasn't aware of shellcheck until today. Nice little tool!
| fi | ||
|
|
||
| helm_output_dir="$SERVICE_CONTROLLER_SOURCE_PATH/helm" | ||
| ag_args="$SERVICE $RELEASE_VERSION -o $SERVICE_CONTROLLER_SOURCE_PATH --template-dirs $TEMPLATES_DIR --aws-sdk-go-version $AWS_SDK_GO_VERSION" |
There was a problem hiding this comment.
Funny, my shellcheck didn't make this suggestion (replacing this string with an array). Curious what command line you used?
There was a problem hiding this comment.
It was actually L211 where it complained about this. Because we are trying to expand a string to use as CLI args, it suggested we use an array of strings rather.
|
Leaving the lgtm-ing to @jljaco |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, jljaco, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Description of changes:
Used the output of the
shellchecktool to make style changes to all of the shell scripts within the repository. Added a newmaketarget forlint-shellwhich lints all of the scripts and excludes SC1091, which fails because wesourceother scripts using path variables (a known limitation ofshellcheck).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.