Complete support for resource-specific resync periods and default drift remediation period #386
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
ack-bot
added
the
do-not-merge/hold
a-hilaly
force-pushed
the
default-sync-period
branch
from
9f6095b to
e0df5a9
Compare
|
@jaypipes Addressed all |
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@a-hilaly can you rebase this please? I see some unrelated changes in the code-gen templates. |
…ft remediation period Issue: aws-controllers-k8s/community#1367 Follow-up of aws-controllers-k8s/runtime#106 This patch completes the implementation of support for resource-specific resync periods and a default drift remediation period made in runtime repository. The resync period for each reconciler is determined by trying to retrieve it from the following sources, in this order: 1. A resource-specific period specified in the drift remediation configuration. 2. A resource-specific requeue on success period specified by the resource manager factory. 3. The default drift remediation period specified in the controller configuration. 4. The default resync period defined in the ACK runtime package. This allows users to customize the drift remediation behavior for different resources as needed, while still providing a fallback option for resources that do not have a specific period specified. Signed-off-by: Amine Hilaly <[email protected]>
a-hilaly
force-pushed
the
default-sync-period
branch
from
e0df5a9 to
e81a8a0
Compare
|
It is normal that the tests don't pass here, we'll need to merge the runtime PR first |
|
/hold |
Signed-off-by: Amine Hilaly <[email protected]>
a-hilaly
force-pushed
the
default-sync-period
branch
from
96b0743 to
70b55da
Compare
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Tested by building an image locally and deploying it using the new helm chart configurations. Works like a rocket! |
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
|
Thank you for testing this again and catching those minor things. Hopefully we get automated regression tests for this "soon" /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Issue: aws-controllers-k8s/community#1367
Follow-up of aws-controllers-k8s/runtime#106
This patch completes the implementation of support for resource-specific
resync periods and a default drift remediation period made in runtime
repository. The resync period for each reconciler is determined by trying
to retrieve it from the following sources, in this order:
This allows users to customize the drift remediation behavior for different
resources as needed, while still providing a fallback option for resources
that do not have a specific period specified.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.